This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
Issue 1 #6
Merged
Issue 1 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from original
meghprkh
suggested changes
Sep 26, 2017
src/QuestionViewer/index.js
Outdated
| (<div> | ||
| <a class="button float-left" href={prev}>Prev</a> | ||
| <a class="button float-right" href={nxt}>Next</a></div>) | ||
| } |
There was a problem hiding this comment.
This could be done much more neatly.
<div>
{qno !== 1 && .....prev....}
{qno !== 5 && .....next....}
</div>
src/QuestionViewer/index.js
Outdated
| res = await res.json(); | ||
| if (!res.error) this.setState({ question: res, loading: false }) | ||
| else this.setState({ error: res.error, loading: false }) | ||
| } | ||
| render() { | ||
| const { loading, question, error } = this.state | ||
| const quesno = parseInt(this.props.params.qno,10) |
There was a problem hiding this comment.
Name it as qno please for consistency
src/QuestionViewer/index.js
Outdated
| res = await res.json(); | ||
| if (!res.error) this.setState({ question: res, loading: false }) | ||
| else this.setState({ error: res.error, loading: false }) | ||
| } | ||
| render() { | ||
| const { loading, question, error } = this.state | ||
| const quesno = parseInt(this.props.params.qno,10) | ||
| const prev = `/question/${quesno-1}` | ||
| const nxt = `/question/${quesno+1}` |
There was a problem hiding this comment.
No need to define as you will use them only once if you code it like I suggested. However your choice.
meghprkh
reviewed
Sep 26, 2017
src/QuestionViewer/index.js
Outdated
| } | ||
| { | ||
| qno!==5 && | ||
| <a class="button float-right" href={`/question/${qno+1}`}> |
There was a problem hiding this comment.
use Link component instead of a like we do in navbar
There was a problem hiding this comment.
Difference is this will not cause the page to reload
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.