Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do nothing for i18n if its config is not set #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do nothing for i18n if its config is not set #2

wants to merge 1 commit into from

Conversation

hharchani
Copy link
Member

No description provided.

@nisargjhaveri
Copy link
Member

The $cfg['i18n']['gettext'] is just for the configuration about gettext, not for the i18n.

If you really want to do this, you should check $cfg['i18n']. Also, as of now, the $cfg['i18n'] is not optional. In various places in the code, it is assumed that it is available and i18n in initialised. We need to take care of those too.

@hharchani
Copy link
Member Author

The issue is locale_accept_from_http needs some package to be installed. There should be a provision for opting out for i18n, if not needed.

@nisargjhaveri
Copy link
Member

Yup.

We need to check if $cfg['i18n'] is set and disable i18n if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hharchani @nisargjhaveri