refactor: crumb generation #187
Conversation
BREAKING CHANGE: baseUrl and trailingSlash properties are now deprecated. Both values are now obtained directly from Astro Config.
Deploying with
|
| Latest commit: |
158df4d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f5a3cd5d.astro-breadcrumbs-docs.pages.dev |
| Branch Preview URL: | https://185-wrong-behavior-when-usin.astro-breadcrumbs-docs.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
===========================================
- Coverage 67.30% 51.41% -15.89%
===========================================
Files 4 3 -1
Lines 263 177 -86
Branches 28 10 -18
===========================================
- Hits 177 91 -86
Misses 86 86 ☔ View full report in Codecov by Sentry. |
felix-berlin
deleted the
185-wrong-behavior-when-using-a-base-url-different-from
branch
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Great job thank you |
|
@mpepito13 thx <3 I am still working on the Docs update. Should be finished today. |
|
Can you add this feature back please? But both should only show About Us as the breadcrumb. With the remove of the baseUrl parameter this is not possible anymore. @felix-berlin |
|
@DavithkbY i created a new issue for this. Unfortunately, I can't promise you that. As soon as I start working more actively on this project again, I'll look for a suitable solution. |
|
@felix-berlin the old solution was kind of perfect :) But thank you for looking into it . |
|
@DavithkbY I see, I'm sorry that it's no longer the case. Until then, you should be fine with v1. |
|
@DavithkbY after this PR, the base url feature is back :) |
BREAKING CHANGE: baseUrl and trailingSlash properties are now deprecated. Both values are now obtained directly from Astro Config.