Decoder Improvements #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of bytes larger than the message size
This change adds a zero_cache counter to the Decoder's state. The implementation uses this cache so that padding bytes aren't pushed into the buffer and need to be removed later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, the Decoder was writing some data (escape sequence bytes, padding bytes) into the Buffer even though that data isn't always part of the user data. This lead to situations where a decoded message that would barely fit into the buffer couldn't be decoded because writing these additional (unneeded) bytes into the buffer failed.
With this PR, the decoder's state handling is adapted such that it only writes data into the buffer when that data belongs to the decoded message. The decoder doesn't use
truncateanymore to remove written bytes from the buffer.Breaking Changes
This PR adds a new member
invalid_padding_bytesto the enum variantDecodeErr::InvalidMessagewhich indicates if any of the padding bytes were invalid (!=0).