Refactor various filesystem related operations to use std::filesystem #309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes use of the std::filesystem API introduced in C++17, and replaces a few instances where variable length arrays and snprintf were being used to construct temporary file paths with std::string (several other places were already using std::string). Using std::filesystem should be a bit more portable than the POSIX function calls that were previously used, which could help get a working native/MinGW build on Windows.
#include <sys/stat.h>
from files where it is no longer needed/tmp
for temporary directory with call to std::filesystem -- on Linux/macOS this returns/tmp
by default unless the user sets an environment variable to override it (TMPDIR
,TMP
,TEMP
,TEMPDIR
), and on Windows this returns the same thing as GetTempPath