-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add troubleshooting section to variables doc #1417
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Michelle Dhanani <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thank you for writing it up! I left a couple of formatting nits but my main thought was to add a bit more remediation information. I've left suggestions although it might be better to treat them as inspiration rather than exact text! But if you're not keen to spend more time on this then no worries, we can merge as is and add more info later.
content/spin/v3/variables.md
Outdated
|
||
```console | ||
Handler returned an error: Error::Undefined("no variable for \"<component-id>\".\"YOUR_VARIABLE\"") | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to add a "how to fix section" here e.g.
To fix this, edit spin.toml
and add to the [component.<component-id>.variables]
table a line such as <your-variable> = "{{ app-variable }}"
. See above for more information.
(sorry cannot figure out how to make GH show the above link as a literal Markdown link but hopefully it makes sense what I mean)
Co-authored-by: itowlson <[email protected]> Signed-off-by: Michelle Dhanani <[email protected]>
Co-authored-by: itowlson <[email protected]> Signed-off-by: Michelle Dhanani <[email protected]>
Co-authored-by: itowlson <[email protected]> Signed-off-by: Michelle Dhanani <[email protected]>
Signed-off-by: Michelle Dhanani <[email protected]>
Signed-off-by: Michelle Dhanani <[email protected]>
@itowlson I think I addressed all your feedback. Thank you. I also added some headings. Wdyt? I'm 50/50 on em. Thanks again. |
Yeah they are pretty heavy eh. But the extra bit of structure is super useful, it really helps the eye to find the different errors/tips! How about if we made them just bold paragraphs instead of headings? Another thought was to put them in terms of the errors people were getting rather than the causes/remedies (because someone with a woe doesn't know the cause/remedy yet, all the know is the error). What do you reckon? Here is how those two changes (together) look on my machine: Better? Worse? |
Content must go through a pre-merge checklist.
Pre-Merge Content Checklist
This documentation has been checked to ensure that:
title
,template
, anddate
are all settemplates/*.hbs
files) that points to a document.md
that is set to publish in the future? If so please only publish the.md
and.hbs
changes in real-time (otherwise there will be a menu item pointing to a.md
file that does not exist)cat -ve <filename> | grep $'\r' | wc -l
and expect 0 as a result)bart check
PREVIEW_MODE=1
and runnpm run styles
to update styling)npm run test
and resolved all errors