Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS key-value store configuration #1423

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

itowlson
Copy link
Contributor

  • @ogghead (can't add you as a reviewer but would appreciate any comments you have - thanks!)

Content must go through a pre-merge checklist.

Pre-Merge Content Checklist

This documentation has been checked to ensure that:

  • The title, template, and date are all set
  • Does this PR have a new menu item (anywhere in templates/*.hbs files) that points to a document .md that is set to publish in the future? If so please only publish the .md and .hbs changes in real-time (otherwise there will be a menu item pointing to a .md file that does not exist)
  • File does not use CRLF, but uses plain LF (hint: use cat -ve <filename> | grep $'\r' | wc -l and expect 0 as a result)
  • Has passed bart check
  • Has been manually tested by running in Spin/Bartholomew (hint: use PREVIEW_MODE=1 and run npm run styles to update styling)
  • Headings are using Title Case
  • Code blocks have the programming language set to properly highlight syntax and the proper copy directive
  • Have tested with npm run test and resolved all errors
  • Relates to an existing (potentially outdated) blog article? If so please add URL in blog to point to this content.

@itowlson itowlson added the spin-3.1 Landing in Spin 3.1 label Nov 22, 2024
@itowlson itowlson linked an issue Nov 22, 2024 that may be closed by this pull request
content/spin/v3/dynamic-configuration.md Outdated Show resolved Hide resolved
content/spin/v3/dynamic-configuration.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ogghead ogghead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny change for clarity, thank you for creating this!

content/spin/v3/dynamic-configuration.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ogghead ogghead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thank you for adding this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doNotMergeYet spin-3.1 Landing in Spin 3.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS key-value backend
4 participants