Skip to content

Commit

Permalink
fix: turned feature flag back on (#1714)
Browse files Browse the repository at this point in the history
  • Loading branch information
RohinBhargava authored Oct 25, 2024
1 parent ec2a6cd commit e3ed412
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/deploy-fdr-prod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
ALGOLIA_APP_ID: ${{ secrets.ALGOLIA_APP_ID }}
ALGOLIA_ADMIN_API_KEY: ${{ secrets.ALGOLIA_ADMIN_API_KEY }}
ALGOLIA_SEARCH_INDEX: ${{ secrets.ALGOLIA_SEARCH_INDEX }}
ALGOLIA_SEARCH_V2_DOMAINS: "workato,rohin-bhargava-staging,monite"
ALGOLIA_SEARCH_V2_DOMAINS: "workato,rohin-bhargava-staging,monite,humanloop,cohere,fern"
ALGOLIA_SEARCH_API_KEY: ${{ secrets.ALGOLIA_SEARCH_API_KEY }}
APPLICATION_ENVIRONMENT: prod
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/diff-fdr-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
ALGOLIA_APP_ID: ${{ secrets.ALGOLIA_APP_ID }}
ALGOLIA_ADMIN_API_KEY: ${{ secrets.ALGOLIA_ADMIN_API_KEY }}
ALGOLIA_SEARCH_INDEX: ${{ secrets.ALGOLIA_SEARCH_INDEX }}
ALGOLIA_SEARCH_V2_DOMAINS: "workato,rohin-bhargava-staging,monite"
ALGOLIA_SEARCH_V2_DOMAINS: "workato,rohin-bhargava-staging,monite,humanloop,cohere,fern"
ALGOLIA_SEARCH_API_KEY: ${{ secrets.ALGOLIA_SEARCH_API_KEY }}
APPLICATION_ENVIRONMENT: dev
steps:
Expand Down
11 changes: 6 additions & 5 deletions servers/fdr/src/services/algolia/AlgoliaService.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { APIV1Db, DocsV1Db } from "@fern-api/fdr-sdk";
import algolia, { type SearchClient } from "algoliasearch";
import { type FdrApplication } from "../../app";
import { getConfig, type FdrApplication } from "../../app";
import { AlgoliaSearchRecordGenerator } from "./AlgoliaSearchRecordGenerator";
import { AlgoliaSearchRecordGeneratorV2 } from "./AlgoliaSearchRecordGeneratorV2";
import type { AlgoliaSearchRecord, ConfigSegmentTuple } from "./types";

Expand Down Expand Up @@ -51,10 +52,10 @@ export class AlgoliaServiceImpl implements AlgoliaService {
configSegmentTuples: ConfigSegmentTuple[];
}) {
return configSegmentTuples.flatMap(([config, indexSegment]) => {
const generator = new AlgoliaSearchRecordGeneratorV2({ docsDefinition, apiDefinitionsById });
// const generator = getConfig().algoliaSearchV2Domains.some((domains) => url.includes(domains))
// ? new AlgoliaSearchRecordGeneratorV2({ docsDefinition, apiDefinitionsById })
// : new AlgoliaSearchRecordGenerator({ docsDefinition, apiDefinitionsById });
// const generator = new AlgoliaSearchRecordGeneratorV2({ docsDefinition, apiDefinitionsById });
const generator = getConfig().algoliaSearchV2Domains.some((domains) => url.includes(domains))
? new AlgoliaSearchRecordGeneratorV2({ docsDefinition, apiDefinitionsById })
: new AlgoliaSearchRecordGenerator({ docsDefinition, apiDefinitionsById });
return generator.generateAlgoliaSearchRecordsForSpecificDocsVersion(config, indexSegment);
});
}
Expand Down

0 comments on commit e3ed412

Please sign in to comment.