Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openrpc): store protocol on each endpoint and use that to generat… #2047

Merged
merged 8 commits into from
Feb 3, 2025

Conversation

dsinghvi
Copy link
Member

Short description of the changes made

Each endpoint in the API Reference now stores the protocol it is associated with (i.e. REST, OpenRPC). This metadata can be used in several ways but the first usecase is for generating accurate curl snippets.

What was the motivation & context behind this PR?

Customer demand.

How has this PR been tested?

Unit tests.

@dsinghvi dsinghvi marked this pull request as ready for review January 22, 2025 16:38
Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com ❌ Failed (Inspect) Jan 22, 2025 4:38pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Jan 22, 2025 4:38pm

@dsinghvi dsinghvi had a problem deploying to Preview - app.buildwithfern.com January 22, 2025 16:39 — with GitHub Actions Error
@dsinghvi dsinghvi had a problem deploying to Preview - app-dev.buildwithfern.com January 22, 2025 16:39 — with GitHub Actions Error
Copy link

Copy link

Copy link

Copy link

github-actions bot commented Jan 22, 2025

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Jan 22, 2025

PR Preview

Copy link

github-actions bot commented Jan 22, 2025

Playwright test results

passed  93 passed
flaky  2 flaky
skipped  2 skipped

Details

stats  97 tests across 9 suites
duration  1 minute, 39 seconds
commit  8d6ee73

Flaky tests

chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for plantstore.dev
chromium › smoke/versioned-docs.spec.ts › Check if https://humanloop.com/docs/v5/api-reference is online

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › websockets/websocket.spec.ts › websocket test

Copy link

@dsinghvi dsinghvi force-pushed the dsinghvi/curl-supports-jsonrpc branch from 925716e to d96c9fb Compare February 3, 2025 20:15
Copy link

github-actions bot commented Feb 3, 2025

Copy link

github-actions bot commented Feb 3, 2025

Copy link

github-actions bot commented Feb 3, 2025

Copy link

github-actions bot commented Feb 3, 2025

@dsinghvi dsinghvi merged commit c87b148 into main Feb 3, 2025
17 of 19 checks passed
@dsinghvi dsinghvi deleted the dsinghvi/curl-supports-jsonrpc branch February 3, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants