Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not stringify final values that are not explicitly set to application/json contentType #2095

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

fern-support
Copy link
Contributor

Fixes FER-4155

Short description of the changes made

We no longer stringify strings, leading to '"string_val"' as the final stringified request body.

What was the motivation & context behind this PR?

TwelveLabs incident.

How has this PR been tested?

pnpm docs:dev

Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com ❌ Failed (Inspect) Jan 30, 2025 8:18pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Jan 30, 2025 8:18pm

@dsinghvi dsinghvi merged commit 5f0680c into main Jan 30, 2025
15 of 16 checks passed
@dsinghvi dsinghvi deleted the eden/fix-playground-string-stringify branch January 30, 2025 20:19
Copy link

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

PR Preview

Copy link

Playwright test results

passed  95 passed
skipped  2 skipped

Details

stats  97 tests across 9 suites
duration  54 seconds
commit  1a5d14b

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › websockets/websocket.spec.ts › websocket test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants