Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link search button #2127

Merged
merged 2 commits into from
Feb 6, 2025
Merged

fix: link search button #2127

merged 2 commits into from
Feb 6, 2025

Conversation

chdeskur
Copy link
Contributor

@chdeskur chdeskur commented Feb 5, 2025

This PR updates the behavior of how the search dialogue is opened so that the search button on medium-sized screens will function properly.

Before:
https://github.com/user-attachments/assets/e4565370-6d79-4356-b8ad-27d27caecef5

After:
https://github.com/user-attachments/assets/ab72b5bd-e19d-42f1-a770-3893042796da

@chdeskur chdeskur requested a review from abvthecity as a code owner February 5, 2025 22:09
Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com ❌ Failed (Inspect) Feb 5, 2025 10:09pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Feb 5, 2025 10:09pm

Copy link

github-actions bot commented Feb 5, 2025

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Feb 5, 2025

PR Preview

Copy link

github-actions bot commented Feb 5, 2025

Playwright test results

passed  99 passed
skipped  2 skipped

Details

stats  101 tests across 9 suites
duration  45.4 seconds
commit  ae4bbd0

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › websockets/websocket.spec.ts › websocket test

@chdeskur chdeskur merged commit 9101c6c into main Feb 6, 2025
16 of 17 checks passed
@chdeskur chdeskur deleted the chdeskur/update-search-button branch February 6, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants