Fix spurious allocation in hasher.Merkleize #171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed a leaky allocation that happens in
merkleizeImpl
.Specifically, https://github.com/ferranbt/fastssz/blob/main/hasher.go#L379 expands the input slice:
but the problem is that the input slice is a sub-slice of h.buf, so if the expansion needs to allocate a new buffer because we're at capacity, then the newly allocated memory area gets thrown away and will not be piled into h.buf to be used subsequently. The result is that calls in a loop will allocate in a loop.
You can verify this by hashing
DepositData
for example, where the last field is 96 bytes, requiring a 32 byte expansion, but since it's at the end of the buffer, it will trigger the case.