Add VTX Temperature Export #950
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemDelaporteMathurin
requested changes
Feb 26, 2025
Comment on lines
+377
to
+378
| mesh = dolfinx.mesh.create_unit_square(MPI.COMM_WORLD, 1, 1) | ||
| V = dolfinx.fem.FunctionSpace(mesh, ("CG", 1)) |
There was a problem hiding this comment.
Why create a unit square mesh everytime??? what if it's a 1D simulation?
You can use the mesh of the simulation directly:
Suggested change
| mesh = dolfinx.mesh.create_unit_square(MPI.COMM_WORLD, 1, 1) | |
| V = dolfinx.fem.FunctionSpace(mesh, ("CG", 1)) | |
| V = dolfinx.fem.FunctionSpace(self.mesh, ("CG", 1)) |
| mesh = dolfinx.mesh.create_unit_square(MPI.COMM_WORLD, 1, 1) | ||
| V = dolfinx.fem.FunctionSpace(mesh, ("CG", 1)) | ||
| temperature_field = dolfinx.fem.Function(V) | ||
| temperature_field.interpolate(lambda x: np.full(x.shape[1], self.temperature_fenics)) |
There was a problem hiding this comment.
Why x.shape[1]?
| @@ -786,6 +805,8 @@ def update_time_dependent_values(self): | |||
| if source.temperature_dependent: | |||
| source.update(t=t) | |||
|
|
|||
| surface_temp_processed = False | |||
There was a problem hiding this comment.
what is this?
Comment on lines
+376
to
+380
| else: | ||
| mesh = dolfinx.mesh.create_unit_square(MPI.COMM_WORLD, 1, 1) | ||
| V = dolfinx.fem.FunctionSpace(mesh, ("CG", 1)) | ||
| temperature_field = dolfinx.fem.Function(V) | ||
| temperature_field.interpolate(lambda x: np.full(x.shape[1], self.temperature_fenics)) |
There was a problem hiding this comment.
I understand that this handles the case where self.temperature_fenics is a fem.Constant. What if this constant is updated in time? Then the newly created fem.Function will not be updated, correct? can we test this?
If that's the case, we probably need to add something to post_processing to update it in time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add VTX Temperature Export for HydrogenTransportProblem Class.
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...