Find max value in parallel safely #953
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #953 +/- ##
========================================
Coverage 96.02% 96.02%
========================================
Files 45 45
Lines 2439 2441 +2
========================================
+ Hits 2342 2344 +2
Misses 97 97 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
I guess we'll need this for maxinum surface, minimum surface, and minimum volume too
Comment on lines
+30
to
+31
| max_value = max(self.field.solution.x.array[indices]) | ||
| MPI.COMM_WORLD.barrier() |
There was a problem hiding this comment.
- I believe we still want to use numpy.max instead of native max here for performance purposes, no?
- what does
barrier()do?
RemDelaporteMathurin
added
the
fenicsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
fix for #900
use MPI to find max value
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...