Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

continue on error #954

Closed
wants to merge 19 commits into from
Closed

continue on error #954

wants to merge 19 commits into from

Conversation

jhdark
Copy link
Collaborator

@jhdark jhdark commented Feb 27, 2025

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.02%. Comparing base (96d62ff) to head (8f3cf61).

Additional details and impacted files
@@           Coverage Diff            @@
##           fenicsx     #954   +/-   ##
========================================
  Coverage    96.02%   96.02%           
========================================
  Files           45       45           
  Lines         2439     2439           
========================================
  Hits          2342     2342           
  Misses          97       97           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jhdark
Copy link
Collaborator Author

jhdark commented Feb 28, 2025

Going to continue testing on a private repo

@jhdark jhdark closed this Feb 28, 2025
@jhdark jhdark deleted the new_ci_warning branch February 28, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant