fix: remove the watermarks (googleapis#1313)

* remove the watermarks Removing the watermarks allows data not to be stuck at the last transform so that data doesn’t get stuck due to the watermarks. * fix: remove the watermarks
feywind · Aug 17, 2023 · 0126a0e · 0126a0e
1 parent a461c17
commit 0126a0e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/table.ts b/src/table.ts
@@ -751,6 +751,7 @@ Please use the format 'prezzy' or '${instance.name}/tables/prezzy'.`);
     let userCanceled = false;
     const userStream = new PassThrough({
       objectMode: true,
+      readableHighWaterMark: 0,
       transform(row, _encoding, callback) {
         if (userCanceled) {
           callback();

diff --git a/test/readrows.ts b/test/readrows.ts
@@ -223,7 +223,7 @@ describe('Bigtable/ReadRows', () => {
   });
 
   // TODO: enable after https://github.com/googleapis/nodejs-bigtable/issues/1286 is fixed
-  it.skip('should be able to stop reading from the read stream when reading asynchronously', function (done) {
+  it('should be able to stop reading from the read stream when reading asynchronously', function (done) {
     if (process.platform === 'win32') {
       this.timeout(60000); // it runs much slower on Windows!
     }
@@ -252,6 +252,7 @@ describe('Bigtable/ReadRows', () => {
     // Transform stream
     const transform = new Transform({
       objectMode: true,
+      writableHighWaterMark: 0,
       transform: (row, _encoding, callback) => {
         setTimeout(() => {
           callback(null, row);