mark final class + add infection

Makefile

@@ -50,7 +50,7 @@ test:
 	$(BASE) ./vendor/bin/phpunit $(COMMAND_ARGS)
 
 infection: dup
-	$(BASE) phpdbg -qrr -d memory_limit=-1 ./vendor/bin/infection -j=5 $(COMMAND_ARGS)
+	$(BASE) ./vendor/bin/infection
 
 # Analyse
 
@@ -61,4 +61,10 @@ cs:
 	$(BASE) php -d memory_limit=-1 ./vendor/bin/phpcs $(COMMAND_ARGS)
 
 cbf: dup
-	$(BASE) php -d memory_limit=-1 ./vendor/bin/phpcbf $(COMMAND_ARGS)
+	$(BASE) php -d memory_limit=-1 ./vendor/bin/phpcbf $(COMMAND_ARGS)
+
+is-valid:
+	$(BASE) ./vendor/bin/phpunit $(COMMAND_ARGS)
+	$(BASE) ./vendor/bin/infection
+	$(BASE) ./vendor/bin/psalm --show-info=true $(COMMAND_ARGS)
+	$(BASE) php -d memory_limit=-1 ./vendor/bin/phpcs $(COMMAND_ARGS)

composer.json

@@ -25,11 +25,13 @@
   "require-dev": {
     "doctrine/coding-standard": "^9.0.0",
     "phpunit/phpunit": "^9.5.20",
-    "vimeo/psalm": "^4.23.0"
+    "vimeo/psalm": "^4.23.0",
+    "infection/infection": "^0.26.10"
   },
   "config": {
     "allow-plugins": {
-      "dealerdirect/phpcodesniffer-composer-installer": true
+      "dealerdirect/phpcodesniffer-composer-installer": true,
+      "infection/extension-installer": true
     }
   },
   "autoload": {

infection.json

@@ -0,0 +1,11 @@
+{
+    "$schema": "vendor/infection/infection/resources/schema.json",
+    "source": {
+        "directories": [
+            "src"
+        ]
+    },
+    "mutators": {
+        "@default": true
+    }
+}

src/BackupManager.php

@@ -19,7 +19,7 @@
  * Once you've done that, your application can interact with the backup manager in one place only
  * and the rest of the system will interact with the new Manager-like construct that you created.
  */
-class BackupManager
+class BackupManager implements BackupManagerContract
 {
     private BackupProcedure $backupProcedure;
     private RestoreProcedure $restoreProcedure;

src/BackupManagerContract.php

@@ -0,0 +1,18 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Fezfez\BackupManager;
+
+use Fezfez\BackupManager\Compressors\Compressor;
+use Fezfez\BackupManager\Databases\Database;
+use Fezfez\BackupManager\Filesystems\BackupManagerFilesystemAdapter;
+use Fezfez\BackupManager\Filesystems\Destination;
+
+interface BackupManagerContract
+{
+    /** @param Destination[] $destinations */
+    public function backup(BackupManagerFilesystemAdapter $localFileSystem, Database $database, array $destinations, string $localTmpPath, Compressor ...$compression): void;
+
+    public function restore(BackupManagerFilesystemAdapter $localFileSystem, BackupManagerFilesystemAdapter $to, string $sourcePath, Database $databaseName, Compressor ...$compression): void;
+}

src/Compressors/GzipCompressor.php

@@ -10,7 +10,7 @@
 use function escapeshellarg;
 use function preg_replace;
 
-class GzipCompressor implements Compressor
+final class GzipCompressor implements Compressor
 {
     private ShellProcessor $shellProcessor;
 

src/Databases/MysqlDatabase.php

@@ -10,7 +10,7 @@
 use function sprintf;
 use function trim;
 
-class MysqlDatabase implements Database
+final class MysqlDatabase implements Database
 {
     private string $host;
     private string $port;

src/Databases/PostgresqlDatabase.php

@@ -7,7 +7,7 @@
 use function escapeshellarg;
 use function sprintf;
 
-class PostgresqlDatabase implements Database
+final class PostgresqlDatabase implements Database
 {
     private string $host;
     private string $port;

src/Filesystems/CantDeleteFile.php

@@ -6,6 +6,6 @@
 
 use RuntimeException;
 
-class CantDeleteFile extends RuntimeException
+final class CantDeleteFile extends RuntimeException
 {
 }

src/Filesystems/CantReadFile.php

@@ -6,6 +6,6 @@
 
 use RuntimeException;
 
-class CantReadFile extends RuntimeException
+final class CantReadFile extends RuntimeException
 {
 }

src/Filesystems/CantWriteFile.php

@@ -6,6 +6,6 @@
 
 use RuntimeException;
 
-class CantWriteFile extends RuntimeException
+final class CantWriteFile extends RuntimeException
 {
 }

src/Filesystems/NotARessource.php

@@ -6,6 +6,6 @@
 
 use RuntimeException;
 
-class NotARessource extends RuntimeException
+final class NotARessource extends RuntimeException
 {
 }

src/Procedures/Backup.php

@@ -15,7 +15,7 @@
 use function sprintf;
 use function uniqid;
 
-class Backup implements BackupProcedure
+final class Backup implements BackupProcedure
 {
     private ShellProcessor $shellProcessor;
 

src/Procedures/Restore.php

@@ -14,7 +14,7 @@
 use function sprintf;
 use function uniqid;
 
-class Restore implements RestoreProcedure
+final class Restore implements RestoreProcedure
 {
     private ShellProcessor $shellProcessor;
 

tests/BackupManagerTest.php

@@ -13,7 +13,7 @@
 use Fezfez\BackupManager\Procedures\RestoreProcedure;
 use PHPUnit\Framework\TestCase;
 
-class BackupManagerTest extends TestCase
+final class BackupManagerTest extends TestCase
 {
     public function testCreateABackupProcedure(): void
     {

tests/Compressors/GzipCompressorTest.php

@@ -9,7 +9,7 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Process\Process;
 
-class GzipCompressorTest extends TestCase
+final class GzipCompressorTest extends TestCase
 {
     /** @return iterable<int, array<string>> */
     public function provideCompress(): iterable

tests/Databases/MysqlDatabaseTest.php

@@ -7,7 +7,7 @@
 use Fezfez\BackupManager\Databases\MysqlDatabase;
 use PHPUnit\Framework\TestCase;
 
-class MysqlDatabaseTest extends TestCase
+final class MysqlDatabaseTest extends TestCase
 {
     public function testGenerateAValidDatabaseDumpCommand(): void
     {
@@ -45,7 +45,7 @@ public function testGenerateAValidDatabaseDumpCommandWithSsl(): void
             'test',
             true,
             true,
-            ['tutu'],
+            ['tutu', ' '],
             ['test']
         );
 

tests/Databases/PostgresqlDatabaseTest.php

@@ -7,7 +7,7 @@
 use Fezfez\BackupManager\Databases\PostgresqlDatabase;
 use PHPUnit\Framework\TestCase;
 
-class PostgresqlDatabaseTest extends TestCase
+final class PostgresqlDatabaseTest extends TestCase
 {
     public function testGenerateAValidDatabaseDumpCommand(): void
     {

tests/Filesystems/BackupManagerRessourceTest.php

@@ -13,7 +13,7 @@
 use function rewind;
 use function stream_get_contents;
 
-class BackupManagerRessourceTest extends TestCase
+final class BackupManagerRessourceTest extends TestCase
 {
     public function testFail(): void
     {

tests/Filesystems/DestinationTest.php

@@ -8,7 +8,7 @@
 use Fezfez\BackupManager\Filesystems\Destination;
 use PHPUnit\Framework\TestCase;
 
-class DestinationTest extends TestCase
+final class DestinationTest extends TestCase
 {
     public function testOk(): void
     {

tests/Procedures/BackupTest.php

@@ -14,7 +14,7 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Process\Process;
 
-class BackupTest extends TestCase
+final class BackupTest extends TestCase
 {
     public function testOk(): void
     {

tests/Procedures/RestoreTest.php

@@ -13,7 +13,7 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Process\Process;
 
-class RestoreTest extends TestCase
+final class RestoreTest extends TestCase
 {
     public function testOk(): void
     {

tests/ShellProcessing/ShellProcessorTest.php

@@ -9,7 +9,7 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Process\Process;
 
-class ShellProcessorTest extends TestCase
+final class ShellProcessorTest extends TestCase
 {
     public function testExecuteACommandLineProcess(): void
     {