Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for OpenResty 1.27.1 compatibility #200

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

GUI
Copy link
Contributor

@GUI GUI commented Feb 3, 2025

Currently if used with OpenResty 1.27.1, the following error is raised:

resty.openssl.auxiliary.nginx development mode doesn't support Nginx version 1027001, please compile nginx with lua-resty-openssl-aux-module or lua-kong-nginx-module.
  • This tries to add compatibility with OpenResty 1.27.1 to the FFI development mode, similar to what was done in fix(aux/nginx) support openresty 1.25.3 in FFI path #147, but I'm not totally sure if this is the best way to go about this or if you want to be testing all these version variants.

  • The new 1.27 tests pass in CI for me, however the older 1.19 and 1.21 tests are failing. But I think that's unrelated to these changes, since those older versions appear to be failing in CI already: https://github.com/fffonion/lua-resty-openssl/actions/runs/12705262705

  • Update: Scratch this last question, I realized I wasn't testing this properly after adding lua-resty-openssl-aux-module. But everything works as expected with resty -e 'require "resty.openssl"; require "resty.openssl.auxiliary.nginx_c"' (just wasn't including the main module first).

    I realize this update is for the "development mode" and this FFI setup isn't recommended for production usage, but I was curious, is lua-resty-openssl-aux-module still functional? I compiled it with OpenResty 1.27.1, and while compiling it was successful, it doesn't appear to work, so lua-resty-openssl still seems to fallback to the FFI version. If I try to explicitly require the C version with lua-resty-openssl-aux-module installed, I still get this error:

    resty -e 'require "resty/openssl/auxiliary/nginx_c"'
    
    ERROR: ...or/lua/share/lua/5.1/resty/openssl/auxiliary/nginx_c.lua:98: declaration specifier expected near 'SSL'

    Am I doing something wrong with the lua-resty-openssl-aux-module installation (I didn't get any errors), or is it no longer compatible with newer versions of OpenResty and doing what's expected?

Thanks!

@fffonion
Copy link
Owner

fffonion commented Feb 5, 2025

Hi @GUI thanks for the report, I'm just back from holiday so haven't been able to fix the build error you mentioned. But it's indeed unrelated. I have kicked the CI on this PR and once it's passed for 1.27.1 I can merged this.

@fffonion fffonion merged commit b75248c into fffonion:master Feb 5, 2025
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants