Update for OpenResty 1.27.1 compatibility #200
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if used with OpenResty 1.27.1, the following error is raised:
This tries to add compatibility with OpenResty 1.27.1 to the FFI development mode, similar to what was done in fix(aux/nginx) support openresty 1.25.3 in FFI path #147, but I'm not totally sure if this is the best way to go about this or if you want to be testing all these version variants.
The new 1.27 tests pass in CI for me, however the older 1.19 and 1.21 tests are failing. But I think that's unrelated to these changes, since those older versions appear to be failing in CI already: https://github.com/fffonion/lua-resty-openssl/actions/runs/12705262705
Update: Scratch this last question, I realized I wasn't testing this properly after adding
lua-resty-openssl-aux-module
. But everything works as expected withresty -e 'require "resty.openssl"; require "resty.openssl.auxiliary.nginx_c"'
(just wasn't including the main module first).I realize this update is for the "development mode" and this FFI setup isn't recommended for production usage, but I was curious, is lua-resty-openssl-aux-module still functional? I compiled it with OpenResty 1.27.1, and while compiling it was successful, it doesn't appear to work, so lua-resty-openssl still seems to fallback to the FFI version. If I try to explicitly require the C version withlua-resty-openssl-aux-module
installed, I still get this error:Am I doing something wrong with the lua-resty-openssl-aux-module installation (I didn't get any errors), or is it no longer compatible with newer versions of OpenResty and doing what's expected?Thanks!