Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Extend AfterSaveJobEvent to make mail sending controllable #17

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sbuerk
Copy link
Contributor

@sbuerk sbuerk commented Feb 18, 2025

The provided JobController already dispatches the PSR-14
AfterSaveJobEvent in the saveJobAction() as notification
event.

The aforementioned event is extended and ...

  • Adds the current plugin settings to allow event listeners
    to process additional tasks based on replaced or extended
    plugin settings (pi_flexform) in projects, which are not
    egitbale as generic solutiion or quick project related
    implementation.
  • Adds listPid as direct option to be read or set and allow
    to base the further handling (redirect) more dynamically on
    project needs, implementing following method signatures:
    • setListPid(?int $listPid): self
    • getListPid(): ?int
  • Adds the current request object to the event to mitigate the
    need to fetch it from $GLOBALS['TYPO3_REQUEST] and missing
    extbase/current state anyway and follow TYPO3 recommendation
    and practice to pass it down.

The provided `JobController` already dispatches the PSR-14
`AfterSaveJobEvent` in the `saveJobAction()` as notification
event.

The aforementioned event is extended and ...

* Adds the current plugin settings to allow event listeners
  to process additional tasks based on replaced or extended
  plugin settings (pi_flexform) in projects, which are not
  egitbale as generic solutiion or quick  project related
  implementation.
* Adds `listPid` as direct option to be read or set and allow
  to base the further handling (redirect) more dynamically on
  project needs, implementing following method signatures:
    - `setListPid(?int $listPid): self`
    - `getListPid(): ?int`
* Adds the current request object to the event to mitigate the
  need to fetch it from `$GLOBALS['TYPO3_REQUEST`] and missing
  extbase/current state anyway and follow TYPO3 recommendation
  and practice to pass it down.
@sbuerk
Copy link
Contributor Author

sbuerk commented Feb 18, 2025

Switching to draft - rethought this and question arised, which needs to be sorted out first. Otherwise it's not clear that this is the route which should be followed, and beeing eventually wrong in the end !

@sbuerk sbuerk marked this pull request as draft February 18, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant