Skip to content

Commit

Permalink
stb#187 Minor self-review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
duker33 committed Sep 20, 2018
1 parent d2c274e commit 4b9119e
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion catalog/context.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,12 @@ def number_url_map(self):
def prepare_tile_products(
products: ProductQuerySet, product_pages: QuerySet, tags: TagQuerySet=None
):
"""
This method works on STB, but not on SE.
This problem will gone when task below will be fixed.
"""

# @todo #550:60m Move prepare_tile_products func to context
# Now it's separated function with huge of inconsistent queryset deps.
assert isinstance(products, ProductQuerySet)
Expand Down Expand Up @@ -432,7 +438,10 @@ def get_context_data(self):
context = self.super.get_context_data()
self.check_pagination_args()

# TODO - return bask this check
# @todo #187:30m Return back empty products list 404 check.
# Now we have problem with stb tests.
# Now stb tests don't aware of it.

# if not self.products:
# raise http.Http404('Page without products does not exist.')

Expand Down

0 comments on commit 4b9119e

Please sign in to comment.