Self-review fixes

fidals · Nov 3, 2018 · 71b896d · 71b896d
1 parent e909cd7
commit 71b896d
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 12 deletions.
diff --git a/catalog/context.py b/catalog/context.py
@@ -288,7 +288,7 @@ def products(self):
             products = (
                 products
                 .filter(tags__in=tags)
-                # See the catalog.context.products.ProductsByTags
+                # See the ProductQuerySet.tagged
                 # for detail about `distinct` and `order_by` above
                 .distinct(*self.get_undirected_sorting_options())
                 .order_by(*self.get_undirected_sorting_options())

diff --git a/catalog/context/__init__.py b/catalog/context/__init__.py
@@ -1,4 +1 @@
-from .products import Products
-from .tags import Tags
-
-# @todo #183:120m Implement Template and PaginatedProducts context classes.
+# @todo #183:120m Implement Page, PaginatedProducts, ProductBrands, ProductsImages context classes.
diff --git a/catalog/context/context.py b/catalog/context/context.py
@@ -30,7 +30,7 @@ def context(self) -> typing.Dict[str, typing.Any]:
 
 class Contexts(Context):
 
-    def __init__(self, contexts: typing.List[Context]):
+    def __init__(self, *contexts: typing.List[Context]):
         self.contexts = contexts
 
     def context(self):

diff --git a/catalog/context/products.py b/catalog/context/products.py
@@ -2,7 +2,7 @@
 
 from django.db.models import QuerySet
 
-from catalog.context.context import Products, Tags, Category
+from catalog.context.context import Products, Tags
 from catalog.models import AbstractCategory
 
 
@@ -29,7 +29,7 @@ def qs(self):
     def context(self):
         return {
             **super().context(),
-            'sorting_index': _sorting_index,
+            'sorting_index': self._sorting_index,
         }
 
 

diff --git a/catalog/context/tags.py b/catalog/context/tags.py
@@ -18,13 +18,12 @@ class ParsedTags(Tags):
 
     def __init__(self, tags: Tags, req_kwargs):
         self._tags = tags
-        self._req_kwargs = req_kwargs
+        self._raw_tags = req_kwargs.get('tags')
 
     def qs(self):
-        raw_tags = self._kwargs.get('tags')
-        if not raw_tags:
+        if not self._raw_tags:
             self._tags.none()
-        return self._tags.parsed(raw_tags)
+        return self._tags.parsed(self._raw_tags)
 
 
 class Checked404Tags(Tags):