-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#140 Clone redirects app #141
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
default_app_config = 'refarm_redirects.apps.RedirectsConfig' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
from django.apps import AppConfig | ||
from django.utils.translation import ugettext_lazy as _ | ||
|
||
|
||
class RedirectsConfig(AppConfig): | ||
name = 'refarm_redirects' | ||
verbose_name = _('refarm_redirects') |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
from django.conf import settings | ||
from django.contrib.redirects.models import Redirect | ||
from django.contrib.redirects.middleware \ | ||
import RedirectFallbackMiddleware \ | ||
as DjangoRedirectFallbackMiddleware | ||
from django.contrib.sites.shortcuts import get_current_site | ||
|
||
|
||
class RedirectFallbackMiddleware(DjangoRedirectFallbackMiddleware): | ||
# reloaded this method | ||
# just to drop `response.status_code` status check | ||
# in base class | ||
def process_response(self, request, response): | ||
full_path = request.get_full_path() | ||
current_site = get_current_site(request) | ||
|
||
r = None | ||
try: | ||
r = Redirect.objects.get(site=current_site, old_path=full_path) | ||
except Redirect.DoesNotExist: | ||
pass | ||
if r is None and settings.APPEND_SLASH and not request.path.endswith('/'): | ||
try: | ||
r = Redirect.objects.get( | ||
site=current_site, | ||
old_path=request.get_full_path(force_append_slash=True), | ||
) | ||
except Redirect.DoesNotExist: | ||
pass | ||
if r is not None: | ||
if r.new_path == '': | ||
return self.response_gone_class() | ||
return self.response_redirect_class(r.new_path) | ||
|
||
# No redirect was found. Return the response. | ||
return response |
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
# @todo:30m Move test case to custom redirects app | ||
# You can find example at SE's tests_views.Redirects app |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fallback
is the wrong part of the class name here, because the PR removes that fallback-like logic in favor of precondition check an existence of redirectsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@artemiy312 , i'll change it to
RedirectAllMiddleware
, yTO-DO