Stb187 tags feature #187
Merged
Stb187 tags feature #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtemijRodionov
requested changes
Sep 21, 2018
catalog/context.py
Outdated
| raise http.Http404('Page without products does not exist.') | ||
| # @todo #187:30m Return back empty products list 404 check. | ||
| # Now we have problem with stb tests. | ||
| # Now stb tests don't aware of it. |
There was a problem hiding this comment.
Uncomment the check for empty products list.
Do it after stb tests will cover a case for it.
catalog/context.py
Outdated
| .filter_by_products(products) | ||
| .get_brands(products) | ||
| ) if tags else defaultdict(lambda: None) | ||
| images = defaultdict() |
There was a problem hiding this comment.
Why did you use defaultdict here? It seems we can use dict instead
duker33
force-pushed
the
stb187_tags_feature
branch
from
9a5314e to
4f922de
Compare
|
merge it. It blocks huge set of tasks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fidals/stroyprombeton#187