#207 Context classes #212
Merged
#207 Context classes #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtemijRodionov
force-pushed
the
207-context-classes
branch
2 times, most recently
from
97ea236 to
bce9ffd
Compare
ArtemijRodionov
force-pushed
the
207-context-classes
branch
from
bce9ffd to
cba2594
Compare
duker33
approved these changes
Nov 13, 2018
catalog/newcontext/__init__.py
Outdated
| @@ -1 +1,2 @@ | |||
| # @todo #183:120m Implement Page, PaginatedProducts, ProductBrands, ProductsImages context classes. | |||
| # @todo #183:120m Implement Page, PaginatedProducts context classes. | |||
| @@ -0,0 +1,62 @@ | |||
| import unittest | |||
There was a problem hiding this comment.
in this tests we don't document=test contexts functionality, but it's inner (and temporary because of it) realization.
I think, that tests should be based on in/out interfaces, but not on inner calls.
But maybe it's about taste and my school
There was a problem hiding this comment.
@duker33 I agree with the point, but unfortunately we still haven't Tag fixtures, so i have to either use mocked objects or create tags at a place of use. I don't like both of these approaches, but right now mocked objects look better.
But maybe it's about taste and my school
It is rather about a difference between the black box testing and the white box testing
ArtemijRodionov
force-pushed
the
207-context-classes
branch
from
949d2f2 to
c17daf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #207