#302 Slugify tags with theirs groups #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtemijRodionov
approved these changes
Mar 6, 2019
catalog/models.py
Outdated
| @@ -401,7 +426,7 @@ class Meta: | |||
| def __str__(self): | |||
| return self.name | |||
|
|
|||
| def _slugify(self) -> None: | |||
| def _get_slug(self) -> str: | |||
| """Make a slug from the name.""" | |||
There was a problem hiding this comment.
This comment is about implementation, that is changing, so let's remove it
| def test_slugify_conflicts(self): | ||
| slugs = [ | ||
| catalog_models.MockTag.objects.create(name=name).slug | ||
| for name in ['11 A', '1/1 A', '1 1 A'] | ||
| for name in ['11 A', '1/1 A', '1 1 A', '1.1 A', '1-1 A', '1_1 A'] |
There was a problem hiding this comment.
Let's create a separate skipped test (e.g. test_slugify_punctuation_conflicts) for the set, that led to the conflict to preserve testing of the set that has no such conflicts 11 A, 1/1 A, 1 1 A
This will help to avoid regressions if we break the slugify for non-conflict set. In common i'd prefer stick to such rule: new tests for new bugs. Up to you
|
|
||
| self.assertEqual(len(slugs), len(set(slugs)), msg=slugs) | ||
|
|
||
| def test_slugs_for_cloned_tag_values(self): |
There was a problem hiding this comment.
Suggested change
| def test_slugs_for_cloned_tag_values(self): | |
| def test_cloned_tag_varied_group_slugs(self): |
Up to you
There was a problem hiding this comment.
i'll leave it because of few points:
- i want to leave
test_slugs_at the beginning - tag values are the same. It's not very common situation, so it's the corner case. That's the point of test problem
- y, groups varying, but it's a normal situation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #302