Skip to content

Commit

Permalink
#394 Redirects dep. stb2 (#397)
Browse files Browse the repository at this point in the history
* - Fix middleware name
- Fix redirects mutlideps
- Inherit redirects app from django's one
- Fix commented code volumes in dc.yml
- Change imports to new redirects app
- Fix commented test and refarm-site dependency
- Create test with unexpected behaviour explaining
- Refresh py reqs according to stb
- Fix rf dep version
- Rm unused import
  • Loading branch information
duker33 authored Jul 9, 2018
1 parent cc7b6ce commit 5a8fa7f
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 6 deletions.
2 changes: 1 addition & 1 deletion docker/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ services:
# contains refarm-site modules
- $DEPS_DIR
# Thus, you can work with apps related to the refarm-site
# - $REFARM_SRC/search:/root/.local/lib/python3.6/site-packages/search
#- $REFARM_DIR/search:/root/.local/lib/python3.6/site-packages/search
command: python manage.py runserver 0.0.0.0:$VIRTUAL_HOST_PORT

nodejs:
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ ua-parser==0.8.0
user-agents==1.1.0
sorl-thumbnail==12.4a1
https://github.com/selwin/django-user_agents/archive/master.zip
https://github.com/fidals/refarm-site/archive/0.1.6.zip
https://github.com/fidals/refarm-site/archive/0.1.7.zip
3 changes: 2 additions & 1 deletion shopelectro/settings/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
'sorl.thumbnail',
'django_select2',
'images',
'refarm_redirects',
'pages',
'catalog',
'search',
Expand All @@ -78,10 +79,10 @@
'django.contrib.auth.middleware.SessionAuthenticationMiddleware',
'django.contrib.messages.middleware.MessageMiddleware',
'django.middleware.clickjacking.XFrameOptionsMiddleware',
'django.contrib.redirects.middleware.RedirectFallbackMiddleware',
'django.middleware.locale.LocaleMiddleware',
'django_user_agents.middleware.UserAgentMiddleware',
'debug_toolbar.middleware.DebugToolbarMiddleware',
'refarm_redirects.middleware.RedirectAllMiddleware',
]

ROOT_URLCONF = 'shopelectro.urls'
Expand Down
3 changes: 0 additions & 3 deletions shopelectro/tests/tests_views.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
They all should be using Django's TestClient.
"""
import json
import unittest
from functools import partial
from itertools import chain
from operator import attrgetter
Expand Down Expand Up @@ -573,8 +572,6 @@ class Redirects(TestCase):

fixtures = ['dump.json']

# will be resurrected at rf#140
@unittest.expectedFailure
def test_redirect_from_existing_page(self):
"""`refarm-site.redirects` app should redirect from existing url too."""
# take some existing `url_from`
Expand Down

0 comments on commit 5a8fa7f

Please sign in to comment.