#533 Set lower bound for gm.yml offers (#545)

shopelectro/management/commands/price.py

@@ -95,9 +95,10 @@ def filter_categories(utm):
 
             return result_categories
 
+        # @todo #533:30m Move `price.prepare_products` logic to `ProductQuerySet`
         def prepare_products(categories_, utm):
             """Filter product list and patch it for rendering."""
-            products_except_others = (
+            products_result_qs = (
                 Product.actives
                 .select_related('page')
                 .prefetch_related('category')
@@ -110,15 +111,21 @@ def prepare_products(categories_, utm):
                 Yandex Market feed requires items in some categories to have pictures
                 To simplify filtering we are excluding all products without pictures
                 """
-                products_except_others = (
-                    products_except_others
+                products_result_qs = (
+                    products_result_qs
                     .filter(page__images__isnull=False)
                     .distinct()
                 )
 
+            if utm == 'GM':
+                products_result_qs = (
+                    products_result_qs
+                    .filter(price__gt=settings.PRICE_GM_LOWER_BOUND)
+                )
+
             result_products = [
                 put_crumbs(put_utm(product))
-                for product in products_except_others
+                for product in products_result_qs
             ]
 
             return result_products

shopelectro/settings/base.py

@@ -484,3 +484,6 @@ def get_robots_content():
 SLUG_HASH_SIZE = 5
 
 BRAND_TAG_GROUP_NAME = 'Производитель'
+
+# products with price lower this value should not be presented at gm.yml price
+PRICE_GM_LOWER_BOUND = 200.0

shopelectro/tests/tests_commands.py

@@ -238,6 +238,15 @@ def test_products_in_price(self):
         products_in_price = self.get_price_offers_node('priceru.xml')
         self.assertEqual(len(products_in_price), Product.objects.count())
 
+    def test_products_in_gm_price_bounds(self):
+        """GM.yml should contain only offers with price > CONST."""
+        offers = self.get_price_offers_node('gm.yml').findall('offer')
+        prices_are_in_bounds = all(
+            float(offer.find('price').text) > settings.PRICE_GM_LOWER_BOUND
+            for offer in offers
+        )
+        self.assertTrue(prices_are_in_bounds)
+
     def test_products_in_yandex_price(self):
         products_in_yandex_price = self.get_price_offers_node('yandex.yml')
         self.assertEqual(