#808 review fixes (#923)

* Apply review fixes

* Create todo to create Goals class

* Skip test_accordion_minimized

shopelectro/tests/tests_js_analytics.py

@@ -96,13 +96,15 @@ def tearDown(self):
         # delete the session to clear the cart
         self.browser.delete_cookie('sessionid')
         self.browser.execute_script('localStorage.clear();')
-        super().setUp()
+        super().tearDown()
 
+    # @todo #808:30m Create Goals class for tests.
+    #  Remove these utility functions in favor of the class.
     def get_goals(self):
         return self.browser.execute_script('return window.dataLayer.results;')
 
     def get_goal(self, reached, index=0):
-        """Get the first reached goal and unfold it."""
+        """Get a goal with the given index and unfold it."""
         return reached[index][0]['ecommerce']
 
     def test_purchase(self):

shopelectro/tests/tests_selenium.py

@@ -857,6 +857,10 @@ def accordion_content(self):
             'js-accordion-content-{}'.format(self.page_top.id)
         )
 
+    # @todo #808:15m Resurrect test_accordion_minimized.
+    #  The test is unstable. https://ci.fidals.com/fidals/shopelectro/1617/10
+
+    @unittest.skip
     def test_accordion_minimized(self):
         """Accordion item should be minimized by default."""
         self.assertFalse(self.accordion_content.is_displayed())