Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests_selenium.py:885: Move Ya.Metrica tests to... #772

Closed
0pdd opened this issue Mar 14, 2019 · 1 comment
Closed

tests_selenium.py:885: Move Ya.Metrica tests to... #772

0pdd opened this issue Mar 14, 2019 · 1 comment
Assignees
@ArtemijRodionov
Labels
2 performer can implement issue at his closest convenient time 30 mins middle-sized issue. Usually a part of feature or a fix cleanup everything that do project stronger, flexible, reusable

Comments

@0pdd
Copy link
Collaborator

0pdd commented Mar 14, 2019

The puzzle 762-afab9051 from #762 has to be resolved:

shopelectro/shopelectro/tests/tests_selenium.py

Line 885 in f97e76b

# @todo #762:30m Move Ya.Metrica tests to tests_js_counters.py

The puzzle was created by Artemiy on 14-Mar-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Mar 14, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Mar 14, 2019
@ArtemijRodionov
#762 #764 google ecommerce tests (#767)
f97e76b 
* Make a mock of google analytics for tests.

* Use SiteDriver instead of seleniumrequests.Remote

* Fix SiteDriver instantiation

* Fix wait

* Create test for google ecommerce

* Remove Remote driver for mobile tests

* Disable celery for GoogleEcommerce test case

* Review fixes

* Apply linter rules
This was referenced Mar 14, 2019
Closed
Closed
@ArtemijRodionov ArtemijRodionov added 30 mins middle-sized issue. Usually a part of feature or a fix 2 performer can implement issue at his closest convenient time cleanup everything that do project stronger, flexible, reusable labels Mar 14, 2019
@ArtemijRodionov ArtemijRodionov self-assigned this Mar 14, 2019
@ArtemijRodionov ArtemijRodionov mentioned this issue Mar 20, 2019
Merged
ArtemijRodionov added a commit that referenced this issue Mar 20, 2019
@ArtemijRodionov
#781 #772 #771 #696 disable huckster and implement google ecommerce t…
62f3cc9 
…est (#782)

* Drop huckster

* Move YandexMetrict test class to test_js_analytics

* Implement test_google_ecommerce_purchase

* Review fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
2 performer can implement issue at his closest convenient time 30 mins middle-sized issue. Usually a part of feature or a fix cleanup everything that do project stronger, flexible, reusable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ArtemijRodionov @0pdd