#781 #772 #771 #696 disable huckster and implement google ecommerce test #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duker33
approved these changes
Mar 20, 2019
| product_vendor_code = Product.objects.first().vendor_code | ||
| self.product_page = reverse('product', args=(product_vendor_code,)) | ||
| self.category_page = reverse( | ||
| 'category', args=(Category.objects.first().page.slug,)) |
There was a problem hiding this comment.
Suggested change
| 'category', args=(Category.objects.first().page.slug,)) | |
| 'category', args=(Category.objects.first().page.slug,) | |
| ) |
| def setUp(self): | ||
| product_vendor_code = Product.objects.first().vendor_code | ||
| self.product_page = reverse('product', args=(product_vendor_code,)) | ||
| self.category_page = reverse( |
There was a problem hiding this comment.
category_path or category_url might be more good name. *_path one is the best, because here we mean part or an url without domain
| def prevent_default(self, event, selector): | ||
| """Use event.preventDefault() to prevent web page reloading.""" | ||
| self.browser.execute_script( | ||
| 'var target = document.querySelector("' + selector + '");' |
There was a problem hiding this comment.
Suggested change
| 'var target = document.querySelector("' + selector + '");' | |
| f'var target = document.querySelector("{selector}");' |
| self.browser.execute_script( | ||
| 'var target = document.querySelector("' + selector + '");' | ||
| 'console.log(target);' | ||
| 'target.on' + event + ' = function(event) {' |
There was a problem hiding this comment.
Suggested change
| 'target.on' + event + ' = function(event) {' | |
| f'target.on{event} = function(event) {' |
| def select_text(self, class_name): | ||
| """Programmatically select text on page.""" | ||
| self.browser.execute_script( | ||
| 'var target = document.getElementsByClassName("' + class_name + '")[0];' |
There was a problem hiding this comment.
Suggested change
| 'var target = document.getElementsByClassName("' + class_name + '")[0];' | |
| f'var target = document.getElementsByClassName("{class_name}")[0];' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #781
Closes #772
Closes #771
Closes #696