Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude non active crums siblings #887

Closed
duker33 opened this issue Jun 21, 2019 · 5 comments · Fixed by #892 or #957
Closed

Exclude non active crums siblings #887

duker33 opened this issue Jun 21, 2019 · 5 comments · Fixed by #892 or #957
Assignees
@duker33
Labels
1 burning issue 30 mins middle-sized issue. Usually a part of feature or a fix bug easy new teammates can start with such issues to become familiar with project from seo

Comments

@duker33
Copy link
Contributor

duker33 commented Jun 21, 2019

It's screen from seo guys
image
@duker33 duker33 added bug from seo 30 mins middle-sized issue. Usually a part of feature or a fix 1 burning issue easy new teammates can start with such issues to become familiar with project labels Jun 21, 2019
@duker33 duker33 self-assigned this Jun 21, 2019
duker33 added a commit that referenced this issue Jun 21, 2019
@duker33
#887 Test if all category.get_siblings are active
0039750
duker33 added a commit that referenced this issue Jun 21, 2019
@duker33
#887 Rm duplicated categories matrix test
5e03321
duker33 added a commit that referenced this issue Jun 21, 2019
@duker33
#887 Remove some code doubling for catalog pagination tests
9adf528
duker33 added a commit that referenced this issue Jun 21, 2019
@duker33
#887 Test if all crumb siblings are active
028cced
duker33 added a commit that referenced this issue Jun 21, 2019
@duker33
#887 Subtask not solved bug investigation
0597b07
@duker33 duker33 mentioned this issue Jun 21, 2019
Merged
duker33 added a commit that referenced this issue Jun 22, 2019
@duker33
#887 Fix siblings test to identify bug
15f6a32
duker33 added a commit that referenced this issue Jun 22, 2019
@duker33
#887 Fix siblings test to identify bug
e401b93
duker33 added a commit that referenced this issue Jun 22, 2019
@duker33
#887 Return the header for product page siblings
632831f
duker33 added a commit that referenced this issue Jun 25, 2019
@duker33
#888,889 Minor remarkup product page (#893)
74374ee 
* #887  Return the header for product page siblings

* #889  Change product content expand button
duker33 added a commit that referenced this issue Jun 25, 2019
@duker33
#887 Review#1 fixes. Rm redundant subtask, simplify test query and co…
bd9620e 
…ndition
duker33 added a commit that referenced this issue Jun 26, 2019
@duker33
#887 Exclude not active crumbs siblings (#892)
9360507 
* #887  Test if all category.get_siblings are active

* #887  Rm duplicated categories matrix test

* #887  Remove some code doubling for catalog pagination tests

* #887  Test if all crumb siblings are active

* #887  Subtask not solved bug investigation

* #887  Fix siblings test to identify bug

* #887  Fix siblings test to identify bug

* #887  Review#1 fixes. Rm redundant subtask, simplify test query and condition
@duker33 duker33 reopened this Sep 15, 2019
@duker33
Copy link
Contributor Author

duker33 commented Sep 15, 2019 •
edited
Loading

pretty the same issue bothers us again. I'll write the new test to identify this issue.
Actual trello task from the seo guys.

Small exploration at the production DB:

root@web:~/prog/shopelectro/docker# dcp exec app python manage.py shell -i python
Python 3.6.6 (default, Sep  5 2018, 03:44:14)
[GCC 6.3.0 20170516] on linux
Type "help", "copyright", "credits" or "license" for more information.
(InteractiveConsole)
>>> from shopelectro.models import Category
>>> Category.objects.get(id=252)
<Category: MP3- колонки>
>>> c = Category.objects.get(id=252)
>>> c.page
<Page: mp3-kolonki-252>
>>> c.page.is_active
False
>>> c.parent
>>> c.page.parent
<Page: catalog>

@duker33 duker33 mentioned this issue Sep 15, 2019
Merged
@duker33
Copy link
Contributor Author

duker33 commented Sep 15, 2019

Covered the case with test, but it won't help.

Tried to remove parent 'catalog' page for the problem non-active category, but got error

>>> from shopelectro.models import Category
>>> c = Category.objects.get(id=252)
>>> c.page.parent = None
>>> c.page.save()

duker33 added a commit that referenced this issue Sep 15, 2019
@duker33
#887 Prove category siblings failure with test
edc6c06
@duker33
Copy link
Contributor Author

duker33 commented Sep 15, 2019

related PR now contains failed siblings mech prof test

duker33 added a commit that referenced this issue Sep 18, 2019
@duker33
#952 Test category root crumb siblings (#957)
2877085 
* #952  Test root crumbs

* #887  Prove category siblings failure with test
@0pdd 0pdd mentioned this issue Sep 18, 2019
Closed
@0pdd
Copy link
Collaborator

0pdd commented Sep 18, 2019

@duker33 the puzzle #961 is still not solved.

@0pdd
Copy link
Collaborator

0pdd commented Sep 24, 2019

@duker33 the only puzzle #961 is solved here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duker33 duker33

Labels
1 burning issue 30 mins middle-sized issue. Usually a part of feature or a fix bug easy new teammates can start with such issues to become familiar with project from seo
Projects
None yet
Milestone
No milestone
2 participants
@duker33 @0pdd