rf#197 Rm prepare_data from context #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtemijRodionov
approved these changes
Nov 2, 2018
shopelectro/views/catalog.py
Outdated
| 'product_images': context_.get_context_data()['product_images'], | ||
| 'product_brands': context_.get_context_data()['product_brands'], |
There was a problem hiding this comment.
Suggested change
| 'product_brands': context_.get_context_data()['product_brands'], | |
| products_ctx = context_.get_context_data() | |
| ... | |
| 'product_images': products_ctx['product_images'], | |
| 'product_brands': products_ctx['product_brands'], |
| class ProductImages(AbstractProductsListContext): | ||
|
|
||
| @property | ||
| def images(self) -> typing.Dict[int, Image]: |
There was a problem hiding this comment.
it is better to be a method, because it perform heavily computations
There was a problem hiding this comment.
@artemiy312 , we already have tags, products, product_pages in the same property-style.
Let's leave as is too keep it's style. And fidals/refarm-site#194 with it's subtasks will solve this problem too
duker33
force-pushed
the
rf197_rm_prepare_data
branch
from
b601db4 to
bff0caf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and customize images context
Depends on fidals/refarm-site#206
fidals/refarm-site#197
fidals/refarm-site#198