#836 Test categories matrix sorting #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtemijRodionov
approved these changes
Jun 11, 2019
| # @todo #822:60m Create tests for the catalog matrix. | ||
| # This cases are would be good to test: | ||
| # - Matrix sorting by page position | ||
| # - Block items limiting |
There was a problem hiding this comment.
Block items limiting
It seems you still haven't test this
There was a problem hiding this comment.
y, did it intentionally. Updated PR body about it
duker33
force-pushed
the
836_limiting_test
branch
from
e54e251 to
0841eee
Compare
sorry, i should wait for rebase on #850 task's code merging |
|
@artemiy312 , it's ready for review |
ArtemijRodionov
approved these changes
Jun 12, 2019
shopelectro/tests/tests_views.py
Outdated
| class CategoriesMatrix(BaseCatalogTestCase): | ||
|
|
||
| fixtures = ['dump.json'] | ||
| URL = reverse_lazy('custom_page', kwargs={'page': 'catalog'}) |
There was a problem hiding this comment.
You can move this to get_page and use reverse instead of reverse_lazy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #836
Didn't test block items limiting. The test should be too complex, for a such minor limiting feature