#977 Send user's phone to CarrotQuest service #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duker33
changed the title
ArtemijRodionov
approved these changes
Sep 30, 2019
| reachGoal('CMN_BUY_SEND'); | ||
| reachGoal('FAST_BUY_SEND'); | ||
| // @todo #977:120m Create some lazy() wrapper for counters. | ||
| // `lazy(my_counter).reachGoal()` should asynchronous delay reaching |
There was a problem hiding this comment.
That GA loader could be helpful as a reference implementation
front/js/shared/tracking.es6
Outdated
| // until my_counter object won't be fully loaded. | ||
|
|
||
| // @todo #977:30m Create mock class for carrotquest. | ||
| // Fill it's methods with console logs. |
There was a problem hiding this comment.
What is this for? Will it be used for testing?
There was a problem hiding this comment.
@artemiy312 , y, for testing. I'll append note about relation to test mech creating #978
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's untested and may be unstable
Closes #977