Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#17 - Add Progress Bar to show progress on perturbations and scores #38

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

jimilp7
Copy link
Contributor

@jimilp7 jimilp7 commented Sep 29, 2023

I would like to contribute!

Solves Issue#17

Requires: TQDM: pip install tqdm

Sample Run:
Screenshot 2023-09-29 at 4 46 56 PM

Comments: These are the places I could find computations for perturbations, if I am missing more, please let me know and I can add those in.

@iterix
Copy link
Contributor

iterix commented Oct 6, 2023

@jimilp7 Thank you for the contribution! 💥

@iterix
Copy link
Contributor

iterix commented Oct 6, 2023

@jimilp7 Loved the addition of progress logger under utils.

Suggested minor changes to comply with lint check. We are good to merge after that. To run lint check locally just use

pip install flake8
make lint

for detailed environment set-up instructions you can refer to https://github.com/fiddler-labs/fiddler-auditor/blob/main/CONTRIBUTION.md

@jimilp7
Copy link
Contributor Author

jimilp7 commented Oct 6, 2023

@jimilp7 Loved the addition of progress logger under utils.

Suggested minor changes to comply with lint check. We are good to merge after that. To run lint check locally just use

pip install flake8 make lint

for detailed environment set-up instructions you can refer to https://github.com/fiddler-labs/fiddler-auditor/blob/main/CONTRIBUTION.md

@iterix Thank you so much for looking into this, just fixed the linter problem!

@iterix
Copy link
Contributor

iterix commented Oct 6, 2023

@jimilp7 Thanks for the quick turnaround! Approved 🚀

@iterix iterix merged commit 033718f into fiddler-labs:main Oct 6, 2023
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants