Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

valid tile template do not need jpg/png #34

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mikelmaron
Copy link

mapbox tile endpoints do not have file suffixes, so adding mapbox tile source fails. tile templates do not require the file suffix be specified.

@thadk
Copy link

thadk commented Jun 28, 2017

I took away these checks on my Docker instance of Field Papers. A Mapbox Studio styles API tiles-based map now displays correctly in the browser--even after atlas creation. For the PDF, though, all the tiles are still coming out completely black with this API, presumably indicating some sort of error like fieldpapers/fieldpapers#139 .

Here is an example User-defined URL (I use #png at the end of the URL to skip the client and server side regex's but effect is same once you apply this patch and remove it) using Mapbox Studio styles which is totally black in PDF:
http://fieldpapers.org/atlases/2d1dtjgf
Creation URL:
http://fieldpapers.org/compose?lat=6.28271&lon=-10.75551&provider=https%3A%2F%2Fapi.mapbox.com%2Fstyles%2Fv1%2Fthadk%2Fcj48xoecv25mj2rogw8ejoguo%2Ftiles%2F256%2F%7Bz%7D%2F%7Bx%7D%2F%7By%7D%3Faccess_token%3Dpk.eyJ1IjoidGhhZGsiLCJhIjoidWlIX1J4OCJ9.BZnfrT_Jdc8aSQyWV8fL7g%23png&title=cannedthad&zoom=17#15/6.2914/-10.7451
via: http://fieldpapers.org/make-canned-atlas-template

@thadk
Copy link

thadk commented Jun 29, 2017

i created a proxy to workaround this issue for Mapbox Studio. The source code and instructions are at https://github.com/thadk/fieldpapers-mapboxstudio-proxy
and the atlas provider proxy server is at https://fieldpapers-mapboxstudio-proxy.herokuapp.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants