Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update F(E)VM FIP Status #1067

Merged
merged 7 commits into from
Sep 18, 2024
Merged

Update F(E)VM FIP Status #1067

merged 7 commits into from
Sep 18, 2024

Conversation

Stebalien
Copy link
Member

  1. Move FIP-0030 to Final (already marked as Final in the README). I've also updated the text to btter reflect what was actually implemented.
  2. Move FIP-0031 to Final (already marked as Final in the README).
  3. Move FIP-0032 to Final (already marked as Final in the README).
  4. Withdraw FIP-0037 (this FIP was replaced by FIP-0054 and FIP-0057).
  5. Move FIP-0054 and FIP-0057 to Final (already marked as Final in the README).

@Stebalien
Move FIP-0030 to Final
572d461 
This has since been shipped in the network, but the FIP language makes
it sound like native Wasm smart contracts are supported. This patch
updates the FIP to make it clear that native Wasm smart contracts were
not implemented.
@Stebalien
Move FIP-0031 to Final
f1af220
@Stebalien
Move FIP-0032 to Final
8adc4cb
@Stebalien
Withdraw FIP-0037
03c4c67 
This FIP was replaced by FIP-0054 and FIP-0057.
@Stebalien
Move FIP-0054 and FIP-0057 to Final
3b45b1c 
These were both implemented as a part of FEVM
lanzafame
lanzafame suggested changes Sep 13, 2024
View reviewed changes
FIPS/fip-0030.md Outdated Show resolved Hide resolved
@Stebalien @lanzafame
fix url
41b7b05 
Co-authored-by: Adrian Lanzafame <[email protected]>
jsoares
jsoares approved these changes Sep 14, 2024
View reviewed changes
Copy link
Member

@jsoares jsoares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have mixed feelings on the substantive updates to FIP-0030, but am inclined to agree that reflecting the reality of what was implemented is more important than preserving what was proposed. Nevertheless, I think it's worth hearing from other editors.

FIPS/fip-0030.md Outdated Show resolved Hide resolved
FIPS/fip-0030.md Outdated Show resolved Hide resolved
@jsoares jsoares merged commit 56863b1 into filecoin-project:master Sep 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanzafame lanzafame lanzafame requested changes

@jennijuju jennijuju jennijuju approved these changes

@jsoares jsoares jsoares approved these changes

@anorth anorth anorth approved these changes

@momack2 momack2 Awaiting requested review from momack2 momack2 is a code owner

@arajasek arajasek Awaiting requested review from arajasek arajasek is a code owner

@kaitlin-beegle kaitlin-beegle Awaiting requested review from kaitlin-beegle kaitlin-beegle is a code owner

@raulk raulk Awaiting requested review from raulk raulk is a code owner

@TippyFlitsUK TippyFlitsUK Awaiting requested review from TippyFlitsUK TippyFlitsUK is a code owner

@rvagg rvagg Awaiting requested review from rvagg rvagg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Stebalien @anorth @jsoares @lanzafame @jennijuju