Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIP-0096: Draft for convert fundraising remainder address(es) to keyless account actor(s) #1080
base: master
Are you sure you want to change the base?
FIP-0096: Draft for convert fundraising remainder address(es) to keyless account actor(s) #1080
Changes from 4 commits
b6437db
4ed1b00
41e6725
44c20af
a84a896
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f0122 only has ~300FIL in it not 2.5% of the network supply at the time this FIP is proposed, and also the last value transfer > 1FIL happened in 2021 Nov. I don’t think this fip improves the network security as it stated by the author.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the input! Appreciate the comments.
i don't think the text suggested there is 2.5%, it reads "whatever it is the remaining of the 2.5%".
That's the point Jorge has been making and the text has been updated to address his comment. I am not sure why editors are fixated on very narrow view of network security. Even a simple question to AI (i used Grok) would give you the following... (point 8 in governance specifically)