Corrected typos #1114
Merged
Corrected typos #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shystrui1199
requested review from
jennijuju,
anorth,
jsoares,
TippyFlitsUK,
momack2,
rvagg,
lanzafame and
dannyob
as code owners
anorth
reviewed
Feb 6, 2025
| @@ -86,7 +86,7 @@ The ConsensusLab team explored potential mitigation strategies and narrowed down | |||
|
|
|||
| --- | |||
|
|
|||
| **Considering the trade-offs, the ConsensusLab team would like to propose the use of synchronous consistent broadcast as the mitigation strategy** (i.e., the last of the three proposed mitigations). The benefits of easy adoption due to only "behind the scence changes" and no <!--fork-->Filecoin-upgrade required, outweigh the shortcomings (timing assumptions). Moreover, even if the timing assumptions are violated, the consistency degrades gracefully (that is, a slightly longer than expected gossip delay would lead to only a small amount of equivocating blocks being accepted rather than to a "cliff phenomenon" where all equivocating blocks are accepted). Also, using the synchronous approach does not require significant changes to the [underlying broadcast protocol](https://blog.ipfs.tech/gossipsubv1.1-eval-report-and-security-audit/), which is already well tested and has built-in failure detecting mechnisms. | |||
you are welcome |
can you merge it ? it will help me in growing up my github portfolio for differ. crypto projects. thank you |
|
Please fix the "behind the scene" line, then we will happily merge. |
"behind the scene" correction
|
Fixed the "behind the scene" line. Can you please check it? |
rvagg
approved these changes
Feb 10, 2025
jsoares
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in:
/FRCs/frc-0087.md ("referensing" → "referencing")
/FRCs/frc-0087.md ("specifing" → "specifying")
/FRCs/frc-0087.md ("specifing" → "specifying")
/FRCs/frc-0051.md ("acording" → "according")
/FRCs/frc-0051.md ("effectivelly" → "effectively")
/FRCs/frc-0051.md ("witholding" → "withholding")
/FRCs/frc-0051.md ("percieved" → "perceived")
/FRCs/frc-0051.md ("targetted" → "targeted")
/FRCs/frc-0051.md ("targetted" → "targeted")
/FRCs/frc-0051.md ("scence" → "scene, science, sense")