Add IsWorkerAddress method #756
Conversation
dcasem
requested review from
momack2,
arajasek,
jennijuju,
kaitlin-beegle,
anorth and
raulk
as code owners
|
|
This proposal isn't discussed in the linked-to discussion (and should really have started a new one). There is some discussion of this proposal in Slack, but it appears to be concluded with an alternative solution to @dcasem's original motivating need here. Do you still intend to advocate for this proposal, or are you satisfied without it for now? I'm sure we'll revisit this when next expanding the built-in APIs anyway. Editor nit: FIP numbers are assigned at the point a draft is reviewed by editors and ready to merge |
| whether a given address belongs to a miner actor as a worker in the Filecoin network. | ||
|
|
||
| ## Change Motivation | ||
| There are several scenarios in the Filecoin protocol where it is necessary to confirm if a particular address belongs to a miner actor as a worker key. Having a dedicated exported method in the miner actorto handle such checks can increase efficiency and readability of the codebase. |
There was a problem hiding this comment.
(Editor comment)
This is a weak motivation without examples. Can you please list 3-4 such examples?
There was a problem hiding this comment.
The primary example is to facilitate associating a miner with a voter, given that many SPs hand over their owner wallet keys to a lender.
| `IsWorkerAddress` correctly identifies the worker address | ||
|
|
||
| `IsWorkerAddress` correctly identifies non-worker addresses |
There was a problem hiding this comment.
(Peer review)
Good that we're thinking about positive and negative testing, but these definitions are a bit unspecific. Consider test cases involving miners that have no worker, and queries with different address types.
| `IsWorkerAddress` correctly identifies non-worker addresses | ||
|
|
||
| ## Implementation | ||
| This FIP does not require any changes to existing protocols. The changes would be implemented in the actor package in the. The exact implementation details will depend on the codebase at the time of implementation. |
There was a problem hiding this comment.
(Peer)
Introducing any change in Wasm bytecode is protocol-breaking because bytecode is referenced by CID.
FIPS/fip-0066.md
Outdated
| The proposed FIP introduces a new built-in actor method to the miner actors for address validation to be used in determining \ | ||
| whether a given address belongs to a miner actor as a worker in the Filecoin network. |
There was a problem hiding this comment.
Same as the Simple Summary, but ok for such a simple FIP. Would be good to cite the method name here.
Co-authored-by: raulk <[email protected]>
Co-authored-by: raulk <[email protected]>
Co-authored-by: raulk <[email protected]>
Co-authored-by: raulk <[email protected]>
Co-authored-by: raulk <[email protected]>
| @@ -0,0 +1,78 @@ | |||
| --- | |||
| fip: "0066" | |||
There was a problem hiding this comment.
Leave as FIP00XX for now. There is already a FIP0066. FIP Editors assign FIP numbers once the draft is reviewed and merged.
| whether a given address belongs to a miner actor as a worker in the Filecoin network. | ||
|
|
||
| ## Change Motivation | ||
| There are several scenarios in the Filecoin protocol where it is necessary to confirm if a particular address belongs to a miner actor as a worker key. Having a dedicated exported method in the miner actorto handle such checks can increase efficiency and readability of the codebase. |
|
Need to resubmit this, I guess. Lost the head repo, so will include new changes in the updated FIP. |
ha - I missed t |
No description provided.