Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ProveCommitSectors3 before the required pre-commit challenge delay has elapsed. #1547

Merged
merged 1 commit into from
May 28, 2024

Conversation

anorth
Copy link
Member

@anorth anorth commented May 27, 2024

No description provided.

Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, with the fmt fixed (https://github.com/filecoin-project/builtin-actors/actions/runs/9260192627/job/25473524246?pr=1547)

but what's the story behind the 2 in the test harness which all uses 3 under the hood, shouldn't we rename that?

@anorth
Copy link
Member Author

anorth commented May 28, 2024

but what's the story behind the 2 in the test harness which all uses 3 under the hood, shouldn't we rename that?

Yes, but right now is bad timing as it will conflict with #1540. @ZenGround0 asked to defer it.

@anorth anorth enabled auto-merge May 28, 2024 02:40
@anorth anorth added this pull request to the merge queue May 28, 2024
Merged via the queue into master with commit 84d40fc May 28, 2024
14 checks passed
@anorth anorth deleted the anorth/pc3test branch May 28, 2024 02:53
ZenGround0 pushed a commit that referenced this pull request Jun 25, 2024
…ay has elapsed. (#1547)

Add a test for calling ProveCommitSectors3 before the required pre-commit challenge delay has elapsed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants