NI-PoRep #1559
Merged
NI-PoRep #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also pushed in a single commit form of #1543 which just adds tests that match filecoin-project/go-state-types#270 (which is merged) |
ZenGround0
approved these changes
Jun 25, 2024
rvagg
force-pushed
the
rvagg/niporep
branch
2 times, most recently
from
5d61fe1
to
6a83b82
Compare
aarshkshah1992
approved these changes
Jun 25, 2024
|
Approving since all review comments in base PR have been addressed and the diff on top of that has also been reviewed. |
aarshkshah1992
pushed a commit
that referenced
this pull request
Jun 25, 2024
* feat(miner): ProveCommitSectorsNI and tests * chore(niporep): fix parameter naming * chore(niporep): improve test function name * chore(niporep): check return values from method * fix(niporep): hard-fail on future sector seal randomness * fix(niporep): properly test aggregate fee payment at boundary * test(miner): add niporep params cbor forms vector tests * chore(miner): extract NI_AGGREGATE_FEE_BASE_SECTOR_COUNT constant --------- Co-authored-by: Nemanja <[email protected]>
aarshkshah1992
pushed a commit
that referenced
this pull request
Jun 25, 2024
* feat(miner): ProveCommitSectorsNI and tests * chore(niporep): fix parameter naming * chore(niporep): improve test function name * chore(niporep): check return values from method * fix(niporep): hard-fail on future sector seal randomness * fix(niporep): properly test aggregate fee payment at boundary * test(miner): add niporep params cbor forms vector tests * chore(miner): extract NI_AGGREGATE_FEE_BASE_SECTOR_COUNT constant --------- Co-authored-by: Nemanja <[email protected]>
aarshkshah1992
added a commit
that referenced
this pull request
Jun 25, 2024
* NI-PoRep (#1559) * feat(miner): ProveCommitSectorsNI and tests * chore(niporep): fix parameter naming * chore(niporep): improve test function name * chore(niporep): check return values from method * fix(niporep): hard-fail on future sector seal randomness * fix(niporep): properly test aggregate fee payment at boundary * test(miner): add niporep params cbor forms vector tests * chore(miner): extract NI_AGGREGATE_FEE_BASE_SECTOR_COUNT constant --------- Co-authored-by: Nemanja <[email protected]> * Update actors version for v14.0 release (#1561) update actors version --------- Co-authored-by: Rod Vagg <[email protected]> Co-authored-by: Nemanja <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains all of #1537 squashed into a single commit (sorry to lose all your excellent progress @NemanjaLu92 but it was getting a bit noisy!), rebased on master so we get #1553, and with additional fixes to address the remaining items listed in the review @ #1537.
My additional changes are the commits on top of the base commit here. Currently this is the diff I'm responsible for here compare to review comments in #1537): 730d6c7...929373a