fip-0100: update the daily sector fee on extension when zero #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
approved these changes
Feb 19, 2025
ZenGround0
reviewed
Feb 19, 2025
actors/miner/src/lib.rs
Outdated
| key | ||
| )); | ||
| } | ||
| deadline_daily_fee_delta += &partition_daily_fee_delta; // non-zero when extending legacy sectors |
There was a problem hiding this comment.
nit: by legacy here you mean pre-fee sectors, something different than ExtensionKind::ExtendCommittmentLegacy. Clarifying this avoids some confusion
ZenGround0
approved these changes
Feb 19, 2025
Stebalien
force-pushed
the
steb/fip-0100/fix-accounting
branch
from
81925bc to
45ca648
Compare
Stebalien
force-pushed
the
steb/fip-0100/update-fee-on-extension
branch
from
c1184db to
3c02c1e
Compare
Base automatically changed from
steb/fip-0100/fix-accounting
to
feat/fip-0100
February 19, 2025 19:38
When, on extension, we encounter a legacy sector with a zero fee, update it based on the current circulating supply.
Stebalien
force-pushed
the
steb/fip-0100/update-fee-on-extension
branch
from
3c02c1e to
fd6ac02
Compare
@rvagg : I haven't had a chance to read filecoin-project/FIPs#1124 yet. Does it cover the relevant FIP updates for this PR? |
|
Yes, this has been covered in filecoin-project/FIPs#1124, along with additional things mentioned in issues in this repo (such as replica updates for legacy sectors which is very similar to this one). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When, on extension, we encounter a legacy sector with a zero fee, update it based on the current circulating supply.
fixes #1634