Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for cleanup on certexchange server shutdown #430

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

Stebalien
Copy link
Member

No description provided.

@Stebalien Stebalien marked this pull request as draft July 8, 2024 11:52
@Stebalien Stebalien force-pushed the steb/cert-server-clean-shutdown branch from 9ecbcc0 to 76b5499 Compare July 8, 2024 11:53
@Stebalien Stebalien marked this pull request as ready for review July 8, 2024 11:55
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 8 lines in your changes missing coverage. Please review.

Project coverage is 74.32%. Comparing base (a06809b) to head (8af04ed).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
- Coverage   74.99%   74.32%   -0.67%     
==========================================
  Files          42       42              
  Lines        3719     3739      +20     
==========================================
- Hits         2789     2779      -10     
- Misses        652      669      +17     
- Partials      278      291      +13     
Files Coverage Δ
certexchange/server.go 59.25% <63.63%> (-9.60%) ⬇️

... and 5 files with indirect coverage changes

@Stebalien Stebalien requested a review from Kubuxu July 8, 2024 12:13
@Stebalien Stebalien force-pushed the steb/cert-server-clean-shutdown branch from 76b5499 to 1213a2b Compare July 8, 2024 12:17
@Stebalien Stebalien removed the request for review from Kubuxu July 8, 2024 13:53
@Stebalien Stebalien requested a review from Kubuxu July 8, 2024 14:06
@Stebalien Stebalien added this pull request to the merge queue Jul 9, 2024
Merged via the queue into main with commit 7782782 Jul 9, 2024
11 of 13 checks passed
@Stebalien Stebalien deleted the steb/cert-server-clean-shutdown branch July 9, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants