Remove redundant CBOR encoding in observer message dump #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Observer uses Parquet and ndjson to dump messages. CBOR encoding seems to be unused. While at it, also remove the unused `GMessageEnvelopeDeferred`.
masih
force-pushed
the
masih/rm-msgdump-cbor
branch
from
b0e8341 to
bcc638a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #726 +/- ##
==========================================
+ Coverage 75.10% 75.16% +0.05%
==========================================
Files 70 70
Lines 6938 6938
==========================================
+ Hits 5211 5215 +4
+ Misses 1314 1311 -3
+ Partials 413 412 -1 |
Stebalien
approved these changes
Oct 28, 2024
Kubuxu
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observer uses Parquet and ndjson to dump messages. CBOR encoding seems to be unused.
While at it, also remove the unused
GMessageEnvelopeDeferred.