Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor log msg adjustment for passive testing finalization skip #764

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Nov 29, 2024

Closes: #760

I think this reflects the intent of the code.

@rvagg rvagg requested a review from masih November 29, 2024 04:33
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.55%. Comparing base (99ae2fc) to head (7cbcb33).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
host.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #764      +/-   ##
==========================================
- Coverage   69.59%   69.55%   -0.04%     
==========================================
  Files          74       74              
  Lines        7551     7551              
==========================================
- Hits         5255     5252       -3     
- Misses       1881     1885       +4     
+ Partials      415      414       -1     
Files with missing lines Coverage Δ
host.go 62.96% <0.00%> (-1.20%) ⬇️

... and 4 files with indirect coverage changes

@masih masih added this pull request to the merge queue Nov 29, 2024
Merged via the queue into main with commit 483e58b Nov 29, 2024
12 of 13 checks passed
@masih masih deleted the rvagg/skip-final branch November 29, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust the log message when EC finalization is disabled
2 participants