Publish containers tagged with version created by uci releaser #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #794 +/- ##
==========================================
- Coverage 69.64% 69.30% -0.35%
==========================================
Files 77 77
Lines 7900 7900
==========================================
- Hits 5502 5475 -27
- Misses 1949 1970 +21
- Partials 449 455 +6 |
rvagg
reviewed
Dec 13, 2024
rvagg
approved these changes
Dec 13, 2024
This repository started using unified CI (uci) a while back to make tagged releases. This release mechanism is triggered by editing the `version.json` which in turn triggers a CI workflow to make a tagged release along with ghithub release etc. The issue with this approach is that because the tag is created by CI it does not trigger other CI jobs that listen to `tags: ['v*']` events. Therefore, since the switch we have only been publishing containers tagged with `main`. The changes here resolve this issue by triggering the GHCR publish workflow whenever releaser wrokflow succeeds. It then fishes out the ref produced by the releaser workflow to use as tagging. This will then give us containers tagged by whatever release we make using uci releaser workflow. Additionally, it adds `type=sha,format=long` tagging to containers for easier debugging and deployment of an explicit commit to `main`.
masih
force-pushed
the
masih/ghcr-publish-on-releaser
branch
from
2bd15a0 to
5b8ecad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repository started using unified CI (uci) a while back to make tagged releases. This release mechanism is triggered by editing the
version.jsonwhich in turn triggers a CI workflow to make a tagged release along with ghithub release etc.The issue with this approach is that because the tag is created by CI it does not trigger other CI jobs that listen to
tags: ['v*']events. Therefore, since the switch we have only been publishing containers tagged withmain.The changes here resolve this issue by triggering the GHCR publish workflow whenever releaser wrokflow succeeds. It then fishes out the ref produced by the releaser workflow to use as tagging. This will then give us containers tagged by whatever release we make using uci releaser workflow.
Additionally, it adds
type=sha,format=longtagging to containers for easier debugging and deployment of an explicit commit tomain.