Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measure time spent on encoding and the compaction ratio #871

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

masih
Copy link
Member

@masih masih commented Feb 4, 2025

Add metrics to measure time spent on encoding CBOR+ZSTD, and the compaction ratio achieved by ZSTD.

Fixes #863

@masih masih requested a review from Stebalien February 4, 2025 13:30
@masih masih force-pushed the masih/encoding-metrics branch from 57f05bf to 72b5e0d Compare February 4, 2025 13:34
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 74.46809% with 12 lines in your changes missing coverage. Please review.

Project coverage is 67.21%. Comparing base (30fac2e) to head (9f9dfa6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/encoding/encoding.go 74.46% 9 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #871      +/-   ##
==========================================
- Coverage   67.21%   67.21%   -0.01%     
==========================================
  Files          84       84              
  Lines        9139     9175      +36     
==========================================
+ Hits         6143     6167      +24     
- Misses       2454     2464      +10     
- Partials      542      544       +2     
Files with missing lines Coverage Δ
internal/encoding/encoding.go 70.11% <74.46%> (+1.48%) ⬆️

... and 3 files with indirect coverage changes

@masih masih self-assigned this Feb 4, 2025
@masih masih added this to the M2: Mainnet Passive Testing milestone Feb 4, 2025
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits/suggestions but otherwise LGTM

internal/encoding/encoding.go Show resolved Hide resolved
internal/encoding/encoding.go Outdated Show resolved Hide resolved
internal/encoding/encoding.go Outdated Show resolved Hide resolved
Add metrics to measure time spent on encoding CBOR+ZSTD, and the
compaction ratio achieved by ZSTD.

Fixes #863
@masih masih force-pushed the masih/encoding-metrics branch from 72b5e0d to 9f9dfa6 Compare February 4, 2025 21:09
@masih masih enabled auto-merge February 4, 2025 21:10
@masih masih added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit e232882 Feb 4, 2025
14 checks passed
@masih masih deleted the masih/encoding-metrics branch February 4, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add metrics to measure compression rate
2 participants