fix(migration): improve job progress logging in MigrateStateTree

[virajbhartiya]

reference to filecoin-project/lotus#12732
This pull request includes an update to the logging format in the MigrateStateTree function to improve clarity during the migration process.

Logging improvements:

• builtin/v9/migration/top.go: Changed the log message to include the percentage of jobs completed and rephrased the message for better readability.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 3.39%. Comparing base (111b58c) to head (2ab8e32).

Files with missing lines	Patch %	Lines
migration/runner.go	0.00%	9 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
- Coverage    3.39%    3.39%   -0.01%     
==========================================
  Files         662      662              
  Lines      177818   177822       +4     
==========================================
  Hits         6041     6041              
- Misses     169928   169932       +4     
  Partials     1849     1849              

Files with missing lines	Coverage Δ
migration/runner.go	0.00% <0.00%> (ø)

[rvagg]

@virajbhartiya do this to builtin/v16/migration/top.go instead of v9. Actors v14 is for network version 25, the next one (which hasn't been scheduled), so it'll actually be used then. v9 on mainnet was in 2022 for nv17.

After each network upgrade, one of the tasks performed is that someone (usually @rjan90) opens a PR here that copies the previous actors to a new version and then copies the most basic migration, without any of the custom stuff that was needed for that last network upgrade. You can see that for v16 here: #325

[rvagg]

Actually, the later migrations run through migration/runner.go, builtin/v16/migration/top.go will be responsible for calling it but the runner is in one place and that's where the logging happens so that's the file you should edit.

[rvagg]

When you watch a migration happen using lotus-shed you might find that percentComplete is not helpful and we need to remove it. I hoped we could do this and my original issue I think said we should, but watching it progress myself we are adding jobs at the same time as completing them, so we never know what "complete" is. I don't think we have an easy way to pre-calculate the number of jobs. So, unfortunately, the main benefit of this logging is simply letting people know that it's happening and that their node isn't stuck.

[virajbhartiya]

Will something like this work

log.Log(rt.INFO, "Performing migration: %s of %s jobs processed (%s/s) [%v elapsed]", doneStr, jobsStr, rateStr, elapsed.Round(time.Second))

even though the done and total jobs will be changing, it will still show that the node isn't stuck and working just fine.