Skip to content

Commit

Permalink
gui-listen fix (#12013)
Browse files Browse the repository at this point in the history
* gui-listen fix

* fix test

---------

Co-authored-by: LexLuthr <[email protected]>
  • Loading branch information
snadrus and LexLuthr authored May 22, 2024
1 parent 7e3846c commit 75ca4de
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 6 deletions.
3 changes: 3 additions & 0 deletions cmd/curio/deps/deps.go
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,9 @@ func (deps *Deps) PopulateRemainingDeps(ctx context.Context, cctx *cli.Context,
}
}
}
if cctx.IsSet("gui-listen") {
deps.Cfg.Subsystems.GuiAddress = cctx.String("gui-listen")
}
if deps.LocalStore == nil {
deps.LocalStore, err = paths.NewLocal(ctx, deps.LocalPaths, deps.Si, []string{"http://" + deps.ListenAddr + "/remote"})
if err != nil {
Expand Down
11 changes: 8 additions & 3 deletions cmd/curio/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@ var runCmd = &cli.Command{
Value: "0.0.0.0:12300",
EnvVars: []string{"CURIO_LISTEN"},
},
&cli.StringFlag{
Name: "gui-listen",
Usage: "host address and port the gui will listen on",
Hidden: true,
},
&cli.BoolFlag{
Name: "nosync",
Usage: "don't check full-node sync status",
Expand Down Expand Up @@ -157,9 +162,9 @@ var webCmd = &cli.Command{
This creates the 'web' layer if it does not exist, then calls run with that layer.`,
Flags: []cli.Flag{
&cli.StringFlag{
Name: "listen",
Usage: "Address to listen on",
Value: "127.0.0.1:4701",
Name: "gui-listen",
Usage: "Address to listen for the GUI on",
Value: "0.0.0.0:4701",
},
&cli.BoolFlag{
Name: "nosync",
Expand Down
2 changes: 1 addition & 1 deletion documentation/en/cli-curio.md
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ DESCRIPTION:
This creates the 'web' layer if it does not exist, then calls run with that layer.
OPTIONS:
--listen value Address to listen on (default: "127.0.0.1:4701")
--gui-listen value Address to listen for the GUI on (default: "0.0.0.0:4701")
--nosync don't check full-node sync status (default: false)
--layers value [ --layers value ] list of layers to be interpreted (atop defaults). Default: base
--help, -h show help
Expand Down
2 changes: 1 addition & 1 deletion documentation/en/default-curio-config.toml
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@
# The address that should listen for Web GUI requests.
#
# type: string
#GuiAddress = ":4701"
#GuiAddress = "0.0.0.0:4701"


[Fees]
Expand Down
2 changes: 1 addition & 1 deletion node/config/def.go
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ const (
func DefaultCurioConfig() *CurioConfig {
return &CurioConfig{
Subsystems: CurioSubsystemsConfig{
GuiAddress: ":4701",
GuiAddress: "0.0.0.0:4701",
BoostAdapters: []string{},
RequireActivationSuccess: true,
RequireNotificationSuccess: true,
Expand Down

0 comments on commit 75ca4de

Please sign in to comment.